Migrate pallet safe mode to umbrella crate #6905
Open
+53
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-gius
added
R0-silent
re-gius
reviewed
Jan 6, 2025
…github.com/Krayt78/polkadot-sdk into migrate-pallet-safe-mode-to-umbrella-crate
re-gius
reviewed
Jan 7, 2025
| BuildStorage, | ||
| use frame::{ | ||
| testing_prelude::*, | ||
| traits::{Everything, IdentityLookup, InsideBoth, InstanceFilter, IsInVec}, |
There was a problem hiding this comment.
same here, move to the umbrella crate everything that's used across several pallets (like IdentityLookup)
There was a problem hiding this comment.
Should we bring the traits to their respective prelude (for example test specific ones go into the test prelude) or do we stuff everything inside the basic prelude ?
There was a problem hiding this comment.
test-specific traits should belong only to the testing prelude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504